Skip to content
This repository was archived by the owner on Sep 21, 2023. It is now read-only.

docs(samples): add samples to create, read, update, and delete products - #150

Merged
parthea merged 26 commits into
googleapis:mainfrom
tetiana-karasova:tutorials-product-crud
Feb 18, 2022
Merged

docs(samples): add samples to create, read, update, and delete products#150
parthea merged 26 commits into
googleapis:mainfrom
tetiana-karasova:tutorials-product-crud

Conversation

@tetiana-karasova

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@tetiana-karasova
tetiana-karasova requested a review from a team as a code owner February 10, 2022 20:57
@tetiana-karasova
tetiana-karasova requested review from a team February 10, 2022 20:57
@product-auto-label product-auto-label Bot added the api: retail Issues related to the googleapis/python-retail API. label Feb 10, 2022
@snippet-bot

snippet-bot Bot commented Feb 10, 2022

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 9 region tags.
You are about to delete 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment
@t-karasova
t-karasova force-pushed the tutorials-product-crud branch from b48bb07 to 0ca1858 Compare February 10, 2022 20:59
@kweinmeister kweinmeister added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 10, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 10, 2022
@kweinmeister kweinmeister added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 10, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 10, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 10, 2022
@kweinmeister kweinmeister added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 11, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 11, 2022
@parthea parthea self-assigned this Feb 12, 2022
@parthea parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Feb 14, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Feb 14, 2022
@kweinmeister kweinmeister added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 14, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 14, 2022
@parthea parthea changed the title Retail Tutorials product crud Feb 15, 2022
@parthea parthea assigned tetiana-karasova and unassigned parthea Feb 15, 2022
@parthea

parthea commented Feb 15, 2022

Copy link
Copy Markdown
Contributor

Hi @tetiana-karasova, Please could you help to resolve the conflicts?

@product-auto-label product-auto-label Bot added the samples Issues that are directly related to samples. label Feb 15, 2022
@parthea

parthea commented Feb 18, 2022

Copy link
Copy Markdown
Contributor

Hi @tetiana-karasova,
There is a test failure with set_inventory_test.py. Please could you take a look?

add_fulfillment_places_test.py .                                         [  9%]
create_product_test.py .                                                 [ 18%]
crud_product_test.py .                                                   [ 27%]
delete_product_test.py .                                                 [ 36%]
get_product_test.py .                                                    [ 45%]
import_products_bq_test.py .                                             [ 54%]
import_products_gcs_test.py .                                            [ 63%]
import_products_inline_test.py .                                         [ 72%]
remove_fulfillment_places_test.py .                                      [ 81%]
set_inventory_test.py F                                                  [ 90%]
update_product_test.py .                                                 [100%]
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 18, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 18, 2022
@parthea parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 18, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 18, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Feb 18, 2022
parthea
parthea previously approved these changes Feb 18, 2022
@parthea

parthea commented Feb 18, 2022

Copy link
Copy Markdown
Contributor

I'll merge once tests pass

@parthea

parthea commented Feb 18, 2022

Copy link
Copy Markdown
Contributor

Hi @tetiana-karasova ,
Please could you take a look at the 2 failing tests?

add_fulfillment_places_test.py .                                         [  9%]
create_product_test.py .                                                 [ 18%]
crud_product_test.py .                                                   [ 27%]
delete_product_test.py .                                                 [ 36%]
get_product_test.py .                                                    [ 45%]
import_products_bq_test.py .                                             [ 54%]
import_products_gcs_test.py F                                            [ 63%]
import_products_inline_test.py .                                         [ 72%]
remove_fulfillment_places_test.py .                                      [ 81%]
set_inventory_test.py F                                                  [ 90%]
update_product_test.py .                                                 [100%]

=================================== FAILURES ===================================
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: retail Issues related to the googleapis/python-retail API. samples Issues that are directly related to samples.

5 participants