Skip to content
This repository was archived by the owner on Apr 20, 2024. It is now read-only.

fix(deps): move libcst to extras - #322

Merged
busunkim96 merged 1 commit into
mainfrom
libcst-extra
Feb 15, 2022
Merged

fix(deps): move libcst to extras#322
busunkim96 merged 1 commit into
mainfrom
libcst-extra

Conversation

@busunkim96

@busunkim96 busunkim96 commented Feb 14, 2022

Copy link
Copy Markdown
Contributor

libcst is only needed to run the fixup script.
@busunkim96
busunkim96 requested a review from parthea February 14, 2022 20:15
@busunkim96
busunkim96 requested a review from a team February 14, 2022 20:15
@product-auto-label product-auto-label Bot added the api: speech Issues related to the googleapis/python-speech API. label Feb 14, 2022
parthea
parthea approved these changes Feb 15, 2022
View reviewed changes

@parthea parthea left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also delete it from the constraints file https://github.com/googleapis/python-speech/blob/main/testing/constraints-3.6.txt#L9?
@busunkim96

busunkim96 commented Feb 15, 2022

Copy link
Copy Markdown
Contributor Author

@parthea Nope! We want extras in there too:

python-speech/testing/constraints-3.6.txt

Lines 3 to 4 in ca99f96

# List *all* library dependencies and extras in this file.
# Pin the version to the lower bound.

@busunkim96
busunkim96 merged commit de6e7c1 into main Feb 15, 2022
@busunkim96
busunkim96 deleted the libcst-extra branch February 15, 2022 15:52
@release-please release-please Bot mentioned this pull request Feb 15, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: speech Issues related to the googleapis/python-speech API.

2 participants

@busunkim96 @parthea