Skip to content

Commit 4672625

Browse files
authored
fix(build): update build info 3 3 x (#16169)
1 parent 8aa10dc commit 4672625

File tree

6 files changed

+16
-11
lines changed

6 files changed

+16
-11
lines changed

‎Makefile

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ logcli: cmd/logcli/logcli ## build logcli executable
142142
logcli-debug: cmd/logcli/logcli-debug ## build debug logcli executable
143143

144144
logcli-image: ## build logcli docker image
145-
$(SUDO) docker build --build-arg=GO_VERSION=$(GO_VERSION) -t $(IMAGE_PREFIX)/logcli:$(IMAGE_TAG) -f cmd/logcli/Dockerfile .
145+
$(SUDO) docker build --build-arg=GO_VERSION=$(GO_VERSION) --build-arg IMAGE_TAG=$(IMAGE_TAG) -t $(IMAGE_PREFIX)/logcli:$(IMAGE_TAG) -f cmd/logcli/Dockerfile .
146146

147147
cmd/logcli/logcli:
148148
CGO_ENABLED=0 go build $(GO_FLAGS) -o $@ ./cmd/logcli
@@ -598,7 +598,7 @@ endef
598598

599599
# promtail
600600
promtail-image: ## build the promtail docker image
601-
$(SUDO) docker build --build-arg=GO_VERSION=$(GO_VERSION) -t $(IMAGE_PREFIX)/promtail:$(IMAGE_TAG) -f clients/cmd/promtail/Dockerfile .
601+
$(SUDO) docker build --build-arg=GO_VERSION=$(GO_VERSION) --build-arg IMAGE_TAG=$(IMAGE_TAG) -t $(IMAGE_PREFIX)/promtail:$(IMAGE_TAG) -f clients/cmd/promtail/Dockerfile .
602602
promtail-image-cross:
603603
$(SUDO) $(BUILD_OCI) --build-arg=GO_VERSION=$(GO_VERSION) -t $(IMAGE_PREFIX)/promtail:$(IMAGE_TAG) -f clients/cmd/promtail/Dockerfile.cross .
604604

@@ -610,7 +610,7 @@ promtail-push: promtail-image-cross
610610

611611
# loki
612612
loki-image: ## build the loki docker image
613-
$(SUDO) docker build --build-arg=GO_VERSION=$(GO_VERSION) -t $(IMAGE_PREFIX)/loki:$(IMAGE_TAG) -f cmd/loki/Dockerfile .
613+
$(SUDO) docker build --build-arg=GO_VERSION=$(GO_VERSION) --build-arg IMAGE_TAG=$(IMAGE_TAG) -t $(IMAGE_PREFIX)/loki:$(IMAGE_TAG) -f cmd/loki/Dockerfile .
614614
loki-image-cross:
615615
$(SUDO) $(BUILD_OCI) --build-arg=GO_VERSION=$(GO_VERSION) -t $(IMAGE_PREFIX)/loki:$(IMAGE_TAG) -f cmd/loki/Dockerfile.cross .
616616

@@ -622,11 +622,11 @@ loki-push: loki-image-cross
622622

623623
# loki-canary
624624
loki-canary-image: ## build the loki canary docker image
625-
$(SUDO) docker build --build-arg=GO_VERSION=$(GO_VERSION) -t $(IMAGE_PREFIX)/loki-canary:$(IMAGE_TAG) -f cmd/loki-canary/Dockerfile .
625+
$(SUDO) docker build --build-arg=GO_VERSION=$(GO_VERSION) --build-arg IMAGE_TAG=$(IMAGE_TAG) -t $(IMAGE_PREFIX)/loki-canary:$(IMAGE_TAG) -f cmd/loki-canary/Dockerfile .
626626
loki-canary-image-cross:
627-
$(SUDO) $(BUILD_OCI) --build-arg=GO_VERSION=$(GO_VERSION) -t $(IMAGE_PREFIX)/loki-canary:$(IMAGE_TAG) -f cmd/loki-canary/Dockerfile.cross .
627+
$(SUDO) $(BUILD_OCI) --build-arg=GO_VERSION=$(GO_VERSION) --build-arg IMAGE_TAG=$(IMAGE_TAG) -t $(IMAGE_PREFIX)/loki-canary:$(IMAGE_TAG) -f cmd/loki-canary/Dockerfile.cross .
628628
loki-canary-image-cross-boringcrypto:
629-
$(SUDO) $(BUILD_OCI) --build-arg=GO_VERSION=$(GO_VERSION) -t $(IMAGE_PREFIX)/loki-canary-boringcrypto:$(IMAGE_TAG) -f cmd/loki-canary-boringcrypto/Dockerfile .
629+
$(SUDO) $(BUILD_OCI) --build-arg=GO_VERSION=$(GO_VERSION) --build-arg IMAGE_TAG=$(IMAGE_TAG) -t $(IMAGE_PREFIX)/loki-canary-boringcrypto:$(IMAGE_TAG) -f cmd/loki-canary-boringcrypto/Dockerfile .
630630
loki-canary-push: loki-canary-image-cross
631631
$(SUDO) $(PUSH_OCI) $(IMAGE_PREFIX)/loki-canary:$(IMAGE_TAG)
632632
loki-canary-push-boringcrypto: loki-canary-image-cross-boringcrypto

‎clients/cmd/promtail/Dockerfile

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
11
ARG GO_VERSION=1.23
2+
ARG IMAGE_TAG
23
FROM golang:${GO_VERSION}-bookworm as build
34

45
COPY . /src/loki
56
WORKDIR /src/loki
67
RUN apt-get update && apt-get install -qy libsystemd-dev
7-
RUN make clean && make BUILD_IN_CONTAINER=false PROMTAIL_JOURNAL_ENABLED=true promtail
8+
RUN make clean && make BUILD_IN_CONTAINER=false PROMTAIL_JOURNAL_ENABLED=true IMAGE_TAG=${IMAGE_TAG} promtail
89

910
# Promtail requires debian or ubuntu as the base image to support systemd journal reading
1011
FROM public.ecr.aws/ubuntu/ubuntu:noble

‎cmd/logcli/Dockerfile

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
11
ARG GO_VERSION=1.23
2+
ARG IMAGE_TAG
23
FROM golang:${GO_VERSION} AS build
34

45
COPY . /src/loki
56
WORKDIR /src/loki
6-
RUN make clean && make BUILD_IN_CONTAINER=false logcli
7+
RUN make clean && make BUILD_IN_CONTAINER=false IMAGE_TAG=${IMAGE_TAG} logcli
78

89

910
FROM gcr.io/distroless/static:debug

‎cmd/loki-canary-boringcrypto/Dockerfile

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
11
ARG GO_VERSION=1.23
2+
ARG IMAGE_TAG
23
FROM golang:${GO_VERSION} as build
34

45
COPY . /src/loki
56
WORKDIR /src/loki
67
RUN go env GOARCH > /goarch
7-
RUN make clean && make GOARCH=$(cat /goarch) BUILD_IN_CONTAINER=true GOEXPERIMENT=boringcrypto loki-canary-boringcrypto
8+
RUN make clean && make GOARCH=$(cat /goarch) BUILD_IN_CONTAINER=true GOEXPERIMENT=boringcrypto IMAGE_TAG=${IMAGE_TAG} loki-canary-boringcrypto
89

910
FROM gcr.io/distroless/base-nossl:debug
1011
COPY --from=build /src/loki/cmd/loki-canary-boringcrypto/loki-canary-boringcrypto /usr/bin/loki-canary

‎cmd/loki-canary/Dockerfile

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
11
ARG GO_VERSION=1.23
2+
ARG IMAGE_TAG
23
FROM golang:${GO_VERSION} AS build
34

45
COPY . /src/loki
56
WORKDIR /src/loki
6-
RUN make clean && make BUILD_IN_CONTAINER=false loki-canary
7+
RUN make clean && make BUILD_IN_CONTAINER=false IMAGE_TAG=${IMAGE_TAG} loki-canary
78

89
FROM gcr.io/distroless/static:debug
910

‎cmd/loki/Dockerfile

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
11
ARG GO_VERSION=1.23
2+
ARG IMAGE_TAG
23
FROM golang:${GO_VERSION} AS build
34

45
COPY . /src/loki
56
WORKDIR /src/loki
6-
RUN make clean && make BUILD_IN_CONTAINER=false loki
7+
RUN make clean && make BUILD_IN_CONTAINER=false IMAGE_TAG=${IMAGE_TAG} loki
78

89
FROM gcr.io/distroless/static:debug
910

0 commit comments

Comments
 (0)