Skip to content

Commit a2c4ea6

Browse files
authored
fix(cd): add loki-image to needs (#19870)
Adding loki-image to the list of trigger-cd needs. Otherwise, trigger-cd is not able to obtain needs.loki-image.outputs.image_tag and the image tag passed to the workflow is empty.
1 parent 698b54f commit a2c4ea6

2 files changed

Lines changed: 2 additions & 1 deletion

File tree

‎.github/release-workflows.jsonnet‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,7 @@ local weeklyImageJobs = {
197197
for name in std.objectFields(weeklyImageJobs)
198198
} + {
199199
'trigger-cd': job.new()
200-
+ job.withNeeds(['loki-manifest', 'loki-canary-manifest'])
200+
+ job.withNeeds(['loki-image', 'loki-manifest', 'loki-canary-manifest'])
201201
+ job.withIf("github.ref == 'refs/heads/main'")
202202
+ job.withPermissions({
203203
contents: 'read',

‎.github/workflows/images.yml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -508,6 +508,7 @@
508508
"IMAGE_TAG": "${{ needs.loki-image.outputs.image_tag }}"
509509
"if": "github.ref == 'refs/heads/main'"
510510
"needs":
511+
- "loki-image"
511512
- "loki-manifest"
512513
- "loki-canary-manifest"
513514
"permissions":

0 commit comments

Comments
 (0)