feat(storage): Azure backend using thanos.io/objstore - #11315
Merged
Conversation
Contributor
|
Trivy scan found the following vulnerabilities:
|
JoaoBraveCoding
force-pushed
the
log-4550-azure
branch
from
March 15, 2024 11:14
9953462 to
e394042
Compare
JoaoBraveCoding
marked this pull request as ready for review
March 18, 2024 15:59
7 tasks
JoaoBraveCoding
commented
Oct 24, 2024
JoaoBraveCoding
left a comment
Collaborator
Author
There was a problem hiding this comment.
lgtm, the adapter was a great idea!
JoaoBraveCoding
commented
Oct 24, 2024
Collaborator
Author
|
Tested and it works 👍 |
chaudum
reviewed
Oct 25, 2024
| "github.com/go-kit/log" | ||
| "github.com/go-kit/log/level" | ||
| "github.com/pkg/errors" | ||
|
|
Contributor
There was a problem hiding this comment.
Wonder why the linter did not catch this empty newline. Please run make format
Comment on lines
+39
to
+43
| func WithRetryableErrFunc(f func(err error) bool) func(*ObjectClientAdapter) { | ||
| return func(o *ObjectClientAdapter) { | ||
| o.isRetryableErr = f | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
nit: Personally I find this is quite an unusual API.
You are supposed to call bucket.WithRetryableErrFunc(func(err error) bool {})(client), right?
chaudum
approved these changes
Oct 25, 2024
| return o | ||
| } | ||
|
|
||
| type options func(*ObjectClientAdapter) |
Contributor
There was a problem hiding this comment.
Suggested change
| type options func(*ObjectClientAdapter) | |
| type ClientOptions func(*ObjectClientAdapter) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it*:
This PR adds support to use the thanos.io/objstore backend for the Azure provider for all components excluding the Ruler since it's similar to the work done in #11132.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Fix how some CLI variables we being passed (some HTTP CLI variables were under.httpwhile others weren't)CLI Table
Checklist
CONTRIBUTING.mdguide (required)CHANGELOG.mdupdatedadd-to-release-noteslabeldocs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR