fix: report correct status code for metric and log queries in metrics.go

[ashwanthgoli]

What this PR does / why we need it:
metrics.go which reports query stats is showing incorrect status code for metric and log queries.
It is incorrectly reporting successful queries with 500 status code.

it also affects the status label in some of the logql_querystats_* metrics

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

• Reviewed the CONTRIBUTING.md guide (required)
• Documentation added
• Tests updated
• CHANGELOG.md updated
  • If the change is worth mentioning in the release notes, add add-to-release-notes label
• Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
• For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
• If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

[na--]

Suggested change

	status := 200
	status := http.StatusOK

[na--]

Hmm does it make sense to add the err != nil check in ClientHTTPStatusAndError() and return 200 there?

Also, this would benefit from a unit test and I'm not sure how easy it would be to do it here (because of the direct call to RecordRangeAndInstantQueryMetrics() that I am not sure we can mock), while doing it in the ClientHTTPStatusAndError() seems much easier.

[sandeepsukhani]

yeah, it makes sense to add a check there.

[cstyan]

@ashwanthgoli bump, I agree with Ned and Sandeep, lets see if moving the check to the server function and be if err == nil, and then just confirm that the rest of the tests are still green