fix(mixins): add backend path section in loki-operational for single scalable deployment - #13023
Conversation
f6dd4be to
753feb2
Compare
Signed-off-by: QuentinBisson <quentin@giantswarm.io>
753feb2 to
8d423d1
Compare
|
sorry for the delay @QuentinBisson, I was away last week, can review this week |
|
@cstyan don't worry about it, I was busy fixing Mimir mixins 😅 Now regarding this one, i was wondering if it would not be better to have a single single scalable resource dashboard instead of having 1 for read, 1 for write and 1 for backend that all contain only 1 row anyway. What do you think? |
that seems like a good idea to me 👍 |
|
PR is here #13471 |
Signed-off-by: QuentinBisson <quentin@giantswarm.io>
75b3a74 to
b30e69d
Compare
|
@cstyan would you be able to review my PRs? |
|
@QuentinBisson again, need to merge in main after the other PRs were merged |
25fd2f8 to
fd99237
Compare
| (import 'dashboards/loki-logs.libsonnet') + | ||
| (import 'dashboards/loki-operational.libsonnet') + | ||
| (import 'dashboards/loki-reads.libsonnet') + | ||
| (import 'dashboards/loki-reads-resources.libsonnet') + |
There was a problem hiding this comment.
did you mean to change this, or was it a linter change?
There was a problem hiding this comment.
I did, I thought having both read dashboards close to each other made sense but I can revert this one of you prefer
What this PR does / why we need it:
This PR adds a backend path row in loki operational just after the read path
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR