fix: Fix HPA ingester typo - #13158
Merged
Merged
Conversation
|
|
|
+1 |
Contributor
Author
|
Looks like #13193 is going through with this change. |
Contributor
|
please fix the conflict and i'll merge it |
Contributor
Author
|
@DylanGuedes Hello! |
DylanGuedes
approved these changes
Jul 11, 2024
DylanGuedes
left a comment
DylanGuedes
left a comment
Contributor
There was a problem hiding this comment.
lgtm! thanks for your contribution ❤️
7 tasks
This was referenced Aug 15, 2024
mraboosk
pushed a commit
to mraboosk/loki
that referenced
this pull request
Oct 7, 2024
**What this PR does / why we need it**: This PR is necessary due to the presence of a typo. With the typo present the following error occurs: ``` no matches for kind "Statefulset" in group "apps" ``` **Which issue(s) this PR fixes**: Fixes grafana#13152
This was referenced Oct 14, 2024
This was referenced Oct 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR is necessary due to the presence of a typo. With the typo present the following error occurs:
Which issue(s) this PR fixes:
Fixes #13152
Special notes for your reviewer:
I haven't contributed much to open source software before - if anything regarding the PR is improper or can be improved, please do tell me! Thanks!
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR