fix(retry): fix retries when using protobuf encoding

[ashwanthgoli]

What this PR does / why we need it:
retry.go expects the Details field of grpc status to be populated which it then uses to read the http response code, it fallbacks to retrying if this field is not set.

But with protobuf encoding Details is not populated and loki retries 4xxs. I do not think it is necessary to set this.

httpgrpc.HTTPResponseFromError gets the Status from the error and additionally tries to decode the http response from Details field. But all retry.go needs is the Code from Status field which would be set for both encoding formats, so replacing this call with status.FromError() which only pulls out the Status from error should fix the retry behaviour.

references:

• Query response status with protobuf encoding is populated here

  loki/pkg/querier/worker/util.go

  Line 142 in 76a764b

  return queryrange.QueryResponseWrapError(err)

• Status from Query response is decoded here. Details are not populated

  loki/pkg/querier/queryrange/marshal.go

  Line 208 in 76a764b

  return nil, status.ErrorProto(res.Status)

• http encoding populates the Details field here along with Status.Code
  

  loki/pkg/querier/queryrange/codec.go

  Line 667 in 76a764b

  return nil, httpgrpc.Errorf(int(r.Code), string(r.Body))

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

• Reviewed the CONTRIBUTING.md guide (required)
• Documentation added
• Tests updated
• Title matches the required conventional commits format, see here
  • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
• Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
• For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
• If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

[duricanikolic]

Could this approach work for you:

  if !IsClientError(err) {
    ...
  }

where

func isClientError(err error) bool {
	if grpcutil.ErrorToStatusCode(err); code/100 == 4 {
		return true
	}
	return false
}

and grpcutil comes from dskit?

[chaudum]

lgtm

[grafanabot]

This PR must be merged before a backport PR will be created.

[grafanabot]

This PR must be merged before a backport PR will be created.