Skip to content

fix(log results cache): include pipeline wrapper disabled in cache key - #13328

Merged
ashwanthgoli merged 1 commit into
mainfrom
logresults-cache-pipeline-wrapper
Jul 8, 2024
Merged

fix(log results cache): include pipeline wrapper disabled in cache key#13328
ashwanthgoli merged 1 commit into
mainfrom
logresults-cache-pipeline-wrapper

Conversation

@ashwanthgoli

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
#12903 missed adding it for log results cache

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@ashwanthgoli
ashwanthgoli marked this pull request as ready for review June 26, 2024 13:17
@ashwanthgoli
ashwanthgoli requested a review from a team as a code owner June 26, 2024 13:17
@MasslessParticle

Copy link
Copy Markdown
Contributor

Can we reuse this? I think it's wise to avoid this file knowing anything about how other cache keys are generated

@ashwanthgoli

Copy link
Copy Markdown
Contributor Author

for some reason log results cache alone uses a different implementation compared to all the other results caches, this change should not affect any other cache keys.

There is some scope for refactoring here to keep the contract consistent with other caching middlewares, but i would leave that for another time

@ashwanthgoli
ashwanthgoli merged commit 221491c into main Jul 8, 2024
@ashwanthgoli
ashwanthgoli deleted the logresults-cache-pipeline-wrapper branch July 8, 2024 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 participants