Skip to content

fix(blooms): Remove unused arg - #13343

Merged
salvacorts merged 1 commit into
mainfrom
salvacorts/bloom-refactor/fix-main
Jun 27, 2024
Merged

fix(blooms): Remove unused arg#13343
salvacorts merged 1 commit into
mainfrom
salvacorts/bloom-refactor/fix-main

Conversation

@salvacorts

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
Folow-up PR for #13341 fixing this check:

https://github.com/grafana/loki/actions/runs/9696539224/job/26758688527
image

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@salvacorts
salvacorts requested a review from a team as a code owner June 27, 2024 13:43
@salvacorts
salvacorts merged commit fcb9b28 into main Jun 27, 2024
@salvacorts
salvacorts deleted the salvacorts/bloom-refactor/fix-main branch June 27, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4 participants