feat(operator): Add support for the volume API - #13369
Merged
Merged
Conversation
periklis
requested changes
Jul 2, 2024
periklis
left a comment
Collaborator
There was a problem hiding this comment.
Besides fixing the unit tests, we need to expose the new limit in the LokiStack CRD.
periklis
requested changes
Jul 2, 2024
periklis
left a comment
Collaborator
There was a problem hiding this comment.
Almost there. Please run make bundle-all to generate all CRDs and bundles.
periklis
reviewed
Jul 2, 2024
periklis
left a comment
Collaborator
There was a problem hiding this comment.
One last thing, missing rendering in internal/manifests/internal/config/loki-runtime-config.yaml for overriding maxVolumeSeries per tenant
periklis
approved these changes
Jul 2, 2024
periklis
reviewed
Jul 2, 2024
…g.yaml Co-authored-by: Periklis Tsirakidis <periklis@nefeli.eu>
periklis
approved these changes
Jul 2, 2024
periklis
pushed a commit
to periklis/loki
that referenced
this pull request
Jul 3, 2024
periklis
pushed a commit
to periklis/loki
that referenced
this pull request
Jul 3, 2024
openshift-merge-bot Bot
added a commit
to openshift/loki
that referenced
this pull request
Jul 3, 2024
[release-5.9] Backport PR grafana#13369
openshift-merge-bot Bot
added a commit
to openshift/loki
that referenced
this pull request
Jul 3, 2024
[release-5.8] Backport PR grafana#13369
periklis
pushed a commit
to periklis/loki
that referenced
this pull request
Jul 3, 2024
periklis
added a commit
to openshift/loki
that referenced
this pull request
Jul 3, 2024
[release-5.6] Backport PR grafana#13369
This was referenced Jul 8, 2024
This was referenced Aug 15, 2024
This was referenced Oct 14, 2024
This was referenced Oct 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR enables the volume API.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
cc @periklis
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR