Skip to content

feat(operator): Add support for the volume API - #13369

Merged
periklis merged 14 commits into
grafana:mainfrom
jatinsu:main
Jul 3, 2024
Merged

feat(operator): Add support for the volume API#13369
periklis merged 14 commits into
grafana:mainfrom
jatinsu:main

Conversation

@jatinsu

@jatinsu jatinsu commented Jul 1, 2024

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
This PR enables the volume API.

Which issue(s) this PR fixes:
None

Special notes for your reviewer:
cc @periklis

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@jatinsu
jatinsu requested review from a team, periklis and xperimental as code owners July 1, 2024 19:38
@CLAassistant

CLAassistant commented Jul 1, 2024

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@periklis periklis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides fixing the unit tests, we need to expose the new limit in the LokiStack CRD.

Comment thread operator/internal/manifests/internal/config/loki-config.yaml Outdated
@periklis periklis changed the title feat: Enable The Volume API for Openshift Jul 2, 2024
@pull-request-size pull-request-size Bot added size/M and removed size/XS labels Jul 2, 2024

@periklis periklis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there. Please run make bundle-all to generate all CRDs and bundles.

Comment thread operator/internal/manifests/internal/config/loki-config.yaml Outdated
@pull-request-size pull-request-size Bot added size/L and removed size/M labels Jul 2, 2024

@periklis periklis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing, missing rendering in internal/manifests/internal/config/loki-runtime-config.yaml for overriding maxVolumeSeries per tenant

@periklis
periklis merged commit d451e23 into grafana:main Jul 3, 2024
periklis pushed a commit to periklis/loki that referenced this pull request Jul 3, 2024
periklis pushed a commit to periklis/loki that referenced this pull request Jul 3, 2024
openshift-merge-bot Bot added a commit to openshift/loki that referenced this pull request Jul 3, 2024
openshift-merge-bot Bot added a commit to openshift/loki that referenced this pull request Jul 3, 2024
periklis pushed a commit to periklis/loki that referenced this pull request Jul 3, 2024
periklis added a commit to openshift/loki that referenced this pull request Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

3 participants