fix(blooms): ensure tokenizer cache is reset between series - #13370
Merged
owen-d merged 2 commits intoJul 1, 2024
Conversation
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
owen-d
force-pushed
the
blooms/reset-tokenizer-cache-between-series
branch
from
July 1, 2024 23:02
94fa5fc to
f95eab1
Compare
grafanabot
pushed a commit
that referenced
this pull request
Jul 2, 2024
![grafana-delivery-bot[bot]](https://cdn.statically.io/img/github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
(cherry picked from commit 04bc3a4)
grafanabot
pushed a commit
that referenced
this pull request
Jul 2, 2024
(cherry picked from commit 04bc3a4)
grafanabot
pushed a commit
that referenced
this pull request
Jul 2, 2024
(cherry picked from commit 04bc3a4)
This was referenced Jul 2, 2024
This was referenced Jul 8, 2024
This was referenced Aug 15, 2024
This was referenced Oct 14, 2024
This was referenced Oct 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes bug where ngrams were not added to blooms b/c they had been added previously to a potentially different series. This caused blooms to fail membership tests incorrectly.