feat(loki): Do not enforce max-query-bytes-read and max-querier-bytes-read in limited tripperware - #13406
Merged
salvacorts merged 2 commits intoJul 4, 2024
Conversation
…-read in limited tripperware
cyriltovena
approved these changes
Jul 4, 2024
cyriltovena
left a comment
Contributor
There was a problem hiding this comment.
LGTM seems fair to me.
salvacorts
marked this pull request as ready for review
July 4, 2024 08:48
salvacorts
deleted the
salvacorts/remove-query-size-limits-limited-queries
branch
July 4, 2024 08:48
This was referenced Jul 8, 2024
This was referenced Aug 15, 2024
This was referenced Oct 14, 2024
This was referenced Oct 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Limited queries without filters will not shard ands return as soon as 1k lines are read. Therefore, the likelyhood of loading too many chunks in memory while processing a query of this type is very low.
As a result, in order to improve the user experience, we have decided to remove the
max-query-bytes-readandmax-querier-bytes-readlimits from the limited tripperware.Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR