fix: Fix panic in BloomStore initialisation - #13457
Merged
Merged
Conversation
The initialisation of the `BloomStore` service failed with a panic if the index gateways were configured to use `ring` mode. This happened, because the bloom store requires to wire up the configuration for the shipper store, see https://github.com/grafana/loki/blob/1a508b0aa/pkg/loki/modules.go#L864-L867 At this time, the index gateway ring manager wasn't initialized yet, leading to a `nil` pointer dereference. This PR fixes the issue by adding the index gateway ring as dependency of the bloom store so it gets initialised first. Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
na--
approved these changes
Jul 9, 2024
chaudum
marked this pull request as ready for review
July 9, 2024 11:08
chaudum
added
type/bug
Contributor
|
This PR must be merged before a backport PR will be created. |
2 similar comments
Contributor
|
This PR must be merged before a backport PR will be created. |
Contributor
|
This PR must be merged before a backport PR will be created. |
grafanabot
pushed a commit
that referenced
this pull request
Jul 9, 2024
![grafana-delivery-bot[bot]](https://cdn.statically.io/img/github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
The initialisation of the `BloomStore` service failed with a panic if the index gateways were configured to use `ring` mode. This happened, because the bloom store requires to wire up the configuration for the shipper store, see https://github.com/grafana/loki/blob/1a508b0aa/pkg/loki/modules.go#L864-L867 At this time, the index gateway ring manager wasn't initialized yet, leading to a `nil` pointer dereference. This PR fixes the issue by adding the index gateway ring as dependency of the bloom store so it gets initialised first. Signed-off-by: Christian Haudum <christian.haudum@gmail.com> (cherry picked from commit 5f4b8fc)
7 tasks
grafanabot
pushed a commit
that referenced
this pull request
Jul 9, 2024
The initialisation of the `BloomStore` service failed with a panic if the index gateways were configured to use `ring` mode. This happened, because the bloom store requires to wire up the configuration for the shipper store, see https://github.com/grafana/loki/blob/1a508b0aa/pkg/loki/modules.go#L864-L867 At this time, the index gateway ring manager wasn't initialized yet, leading to a `nil` pointer dereference. This PR fixes the issue by adding the index gateway ring as dependency of the bloom store so it gets initialised first. Signed-off-by: Christian Haudum <christian.haudum@gmail.com> (cherry picked from commit 5f4b8fc)
7 tasks
This was referenced Aug 15, 2024
This was referenced Oct 14, 2024
This was referenced Oct 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The initialisation of the
BloomStoreservice failed with a panic if the index gateways were configured to useringmode.This happened, because the bloom store requires to wire up the configuration for the shipper store, see
https://github.com/grafana/loki/blob/1a508b0aa/pkg/loki/modules.go#L864-L867
At this time, the index gateway ring manager wasn't initialized yet, leading to a
nilpointer dereference.This PR fixes the issue by adding the index gateway ring as dependency of the bloom store so it gets initialised first.
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR