feat(mixins): merge resources dashboards for ssd into one - #13471
Merged
cstyan merged 3 commits intoSep 18, 2024
Merged
Conversation
QuentinBisson
force-pushed
the
mixins-add-resource-overview-dashboard-for-ssd
branch
from
July 10, 2024 11:42
aba5b93 to
1f3afb0
Compare
Contributor
Author
|
@cstyan or @MichelHollands I would love some inputs if you have the time of course |
Merged
7 tasks
Contributor
|
@QuentinBisson am I understanding correctly, this should supersede your other PR #13023 ? |
Contributor
Author
|
Yes and no 😅 because thé other PR also include the addition of a backend path in the Loki opérational dashboard so I will rename it later on :) |
Contributor
|
@QuentinBisson need to merge in again after some of the other PRs have been merged |
…w dashboard Signed-off-by: QuentinBisson <quentin@giantswarm.io>
QuentinBisson
force-pushed
the
mixins-add-resource-overview-dashboard-for-ssd
branch
from
September 18, 2024 13:53
0394cc0 to
105894f
Compare
Contributor
Author
|
Should be good @cstyan :) |
cstyan
approved these changes
Sep 18, 2024
Contributor
Author
|
Hey @cstyan I regened the mixins on my hand but I have some weird layout on this one I think I need to play with |
7 tasks
Contributor
Author
|
Fix here #14178 😄 |
This was referenced Oct 14, 2024
This was referenced Oct 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What this PR does / why we need it:
Single Scalable deployment mixins were not showing the full resource usage as the backend pods were ignored.
This PR merges the existing read-resources and write resources dashboard into 1 for SSD and adds the backend resources. The idea was already communicated in with @cstyan in this PR #13023
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR