Skip to content

fix: add logging to empty bloom - #13502

Merged
salvacorts merged 2 commits into
mainfrom
salvacorts/log-line-empty-bloom
Jul 12, 2024
Merged

fix: add logging to empty bloom#13502
salvacorts merged 2 commits into
mainfrom
salvacorts/log-line-empty-bloom

Conversation

@salvacorts

@salvacorts salvacorts commented Jul 12, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
Follow up for #13500 to log the empty blooms with their block and offset.

I also moved the bloom empty check outside the reqs loop.

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@salvacorts
salvacorts marked this pull request as ready for review July 12, 2024 08:01
@salvacorts
salvacorts requested a review from a team as a code owner July 12, 2024 08:01
chaudum
chaudum reviewed Jul 12, 2024
View reviewed changes
Comment thread pkg/storage/bloom/v1/fuse.go Outdated
// In the case we don't have any data in the bloom, don't filter any chunks.
if bloom.ScalableBloomFilter.Count() == 0 {
level.Warn(fq.logger).Log(
"Found bloom with no data",

@chaudum chaudum Jul 12, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Found bloom with no data",
"msg", "found bloom with no data",

@salvacorts salvacorts Jul 12, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done
@salvacorts
salvacorts merged commit c263a68 into main Jul 12, 2024
@salvacorts
salvacorts deleted the salvacorts/log-line-empty-bloom branch July 12, 2024 08:11
@salvacorts salvacorts added type/bug Somehing is not working as expected backport k210 labels Jul 12, 2024
grafanabot pushed a commit that referenced this pull request Jul 12, 2024
@salvacorts grafana-delivery-bot[bot]
fix: add logging to empty bloom (#13502)
1ea92de 
(cherry picked from commit c263a68)
@grafanabot grafanabot mentioned this pull request Jul 12, 2024
Merged
7 tasks
@loki-gh-app loki-gh-app Bot mentioned this pull request Jul 15, 2024
Closed
@loki-gh-app loki-gh-app Bot mentioned this pull request Jul 22, 2024
Closed
This was referenced Aug 15, 2024
Closed
Closed
@loki-gh-app loki-gh-app Bot mentioned this pull request Sep 9, 2024
Merged
@loki-gh-app loki-gh-app Bot mentioned this pull request Sep 23, 2024
Closed
@loki-gh-app loki-gh-app Bot mentioned this pull request Sep 30, 2024
Closed
@loki-gh-app loki-gh-app Bot mentioned this pull request Oct 7, 2024
Closed
This was referenced Oct 14, 2024
Closed
Closed
This was referenced Oct 21, 2024
Closed
Closed
@loki-gh-app loki-gh-app Bot mentioned this pull request Nov 4, 2024
Merged
@loki-gh-app loki-gh-app Bot mentioned this pull request Nov 11, 2024
Closed
@loki-gh-app loki-gh-app Bot mentioned this pull request Dec 4, 2024
Closed
@loki-gh-app loki-gh-app Bot mentioned this pull request Dec 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport k210 size/S type/bug Somehing is not working as expected

2 participants

@salvacorts @chaudum