fix(blooms): Remove backoff from notify planner - #13506
Merged
salvacorts merged 1 commit intoJul 15, 2024
Merged
Conversation
chaudum
approved these changes
Jul 15, 2024
salvacorts
deleted the
salvacorts/bloom-refactor/builderloop-fail-on-planner-restart
branch
July 15, 2024 07:34
This was referenced Aug 15, 2024
4 tasks
This was referenced Oct 14, 2024
This was referenced Oct 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In #13306 we implemented a backoff mechanism to retry connecting to the builder. We added a backoff to connect to the builder to receive tasks, and another one to send back the results.
In this PR we remove the backoff to send back the result. I ran some experiments and:
We can revisit this if we decide to make the planner tolerant to restarts and make it able to pick it up where it failed.
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR