Skip to content

fix: fix retry code to handle grpc status codes. updated newer stats retries to be wrapped with spans - #13592

Merged
slim-bean merged 1 commit into
mainfrom
fix-retries
Jul 20, 2024
Merged

fix: fix retry code to handle grpc status codes. updated newer stats retries to be wrapped with spans#13592
slim-bean merged 1 commit into
mainfrom
fix-retries

Conversation

@slim-bean

@slim-bean slim-bean commented Jul 20, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:

In our retry middleware we were checking for HTTP status codes to determine if an error should be retried internally, however there are cases where we respond with GRPC status codes that we were not properly handling leading to some transient errors being propagated back to the user which can be caught with simple retries.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@slim-bean
fix retry code to handle grpc status codes. updated newer stats retri…
a905f09 
…es to be wrapped with spans

Signed-off-by: Edward Welch <edward.welch@grafana.com>
@slim-bean
slim-bean requested a review from a team as a code owner July 20, 2024 12:23
@slim-bean
slim-bean merged commit d3e1edb into main Jul 20, 2024
@slim-bean
slim-bean deleted the fix-retries branch July 20, 2024 18:35
grafanabot pushed a commit that referenced this pull request Jul 20, 2024
@slim-bean grafana-delivery-bot[bot]
fix: fix retry code to handle grpc status codes. updated newer stats …
f7dbbf4 
…retries to be wrapped with spans (#13592)

Signed-off-by: Edward Welch <edward.welch@grafana.com>
(cherry picked from commit d3e1edb)
@grafanabot grafanabot mentioned this pull request Jul 20, 2024
Merged
7 tasks
@loki-gh-app loki-gh-app Bot mentioned this pull request Jul 22, 2024
Closed
@slim-bean slim-bean mentioned this pull request Jul 22, 2024
Merged
7 tasks
This was referenced Jul 22, 2024
Merged
Merged
This was referenced Aug 15, 2024
Closed
Closed
@loki-gh-app loki-gh-app Bot mentioned this pull request Sep 9, 2024
Merged
@loki-gh-app loki-gh-app Bot mentioned this pull request Sep 23, 2024
Closed
@loki-gh-app loki-gh-app Bot mentioned this pull request Sep 30, 2024
Closed
@loki-gh-app loki-gh-app Bot mentioned this pull request Oct 7, 2024
Closed
This was referenced Oct 14, 2024
Closed
Closed
This was referenced Oct 21, 2024
Closed
Closed
@loki-gh-app loki-gh-app Bot mentioned this pull request Nov 4, 2024
Merged
@loki-gh-app loki-gh-app Bot mentioned this pull request Nov 11, 2024
Closed
@loki-gh-app loki-gh-app Bot mentioned this pull request Dec 4, 2024
Closed
@loki-gh-app loki-gh-app Bot mentioned this pull request Dec 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment