fix: remove retries on the stats handlers because they already retry - #13608
Conversation
Signed-off-by: Edward Welch <edward.welch@grafana.com>
|
Hello @ashwanthgoli!
Please, if the current pull request addresses a bug fix, label it with the |
|
Hello @ashwanthgoli!
Please, if the current pull request addresses a bug fix, label it with the |
|
This PR must be merged before a backport PR will be created. |
What this PR does / why we need it:
#13584 added retries to the stats handlers because I had seen some 5xx errors on stats functions not being retried. it was pointed out we already have retries on the statshandler, the tripperware used here already includes it.
Instead it seems the 5xx's that were not retried were fixed in #13592 so this PR removes the duplicate retry
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR