fix(helm): removed helm test - #13651
Merged
Merged
Conversation
JStickler
approved these changes
Jul 24, 2024
JStickler
left a comment
Contributor
There was a problem hiding this comment.
[docs team] Approving so that we can unblock users.
Contributor
Author
|
@JStickler does this need a helm version bump? I assume so |
Contributor
|
@Jayclifford345 Yes, please bump the version. |
Contributor
Author
|
Version bumped to |
Contributor
|
Version needs to be updated in three files. |
Contributor
Author
|
Okay think I both of those places updated |
ajruli
reviewed
Jul 24, 2024
Contributor
Author
|
@edspace added a new line in gitignore. The tests will run again the integration test took 10 minutes last time :( |
7 tasks
This was referenced Aug 15, 2024
mraboosk
pushed a commit
to mraboosk/loki
that referenced
this pull request
Oct 7, 2024
This was referenced Oct 14, 2024
This was referenced Oct 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed helm test
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR