Skip to content

fix(helm): removed helm test - #13651

Merged
JStickler merged 5 commits into
mainfrom
hotfix-loki-helm-test
Jul 24, 2024
Merged

fix(helm): removed helm test#13651
JStickler merged 5 commits into
mainfrom
hotfix-loki-helm-test

Conversation

@Jayclifford345

Copy link
Copy Markdown
Contributor

Removed helm test

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@Jayclifford345
Jayclifford345 requested a review from a team as a code owner July 24, 2024 16:10

@JStickler JStickler left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[docs team] Approving so that we can unblock users.

@Jayclifford345

Copy link
Copy Markdown
Contributor Author

@JStickler does this need a helm version bump? I assume so

@Jayclifford345 Jayclifford345 changed the title fix:removed helm test Jul 24, 2024
@JStickler

Copy link
Copy Markdown
Contributor

@Jayclifford345 Yes, please bump the version.

@Jayclifford345

Copy link
Copy Markdown
Contributor Author

Version bumped to 6.7.3

@JStickler

Copy link
Copy Markdown
Contributor

Version needs to be updated in three files.
For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md.

@Jayclifford345 Jayclifford345 changed the title fix: removed helm test Jul 24, 2024
@Jayclifford345

Copy link
Copy Markdown
Contributor Author

Okay think I both of those places updated

Comment thread .gitignore Outdated
@Jayclifford345

Copy link
Copy Markdown
Contributor Author

@edspace added a new line in gitignore. The tests will run again the integration test took 10 minutes last time :(

@JStickler
JStickler merged commit ef03476 into main Jul 24, 2024
@JStickler
JStickler deleted the hotfix-loki-helm-test branch July 24, 2024 17:34
mraboosk pushed a commit to mraboosk/loki that referenced this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

3 participants