fix(helm): admin-api should only be deployed in microservice mode - #13655
Merged
Conversation
Signed-off-by: Bradley Pettit <12028233+bradleypettit@users.noreply.github.com>
Signed-off-by: Bradley Pettit <12028233+bradleypettit@users.noreply.github.com>
Signed-off-by: Bradley Pettit <12028233+bradleypettit@users.noreply.github.com>
Signed-off-by: Bradley <12028233+bradleypettit@users.noreply.github.com>
Signed-off-by: Bradley <12028233+bradleypettit@users.noreply.github.com>
Contributor
|
At first glance it looks good to me |
Contributor
|
@bradleypettit do you mind fixing the conflicts? |
Signed-off-by: Bradley <12028233+bradleypettit@users.noreply.github.com>
Contributor
Author
|
Thanks @QuentinBisson - conflicts resolved and re-tested OK in my lab environment. |
Contributor
|
@Jayclifford345 could you take care of this one? LGTM |
Signed-off-by: Jay Clifford <45856600+Jayclifford345@users.noreply.github.com>
Signed-off-by: J Stickler <julie.stickler@grafana.com>
This was referenced Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Enterprise deployments using SSD are expected to use the admin-api service within the backend pods. After the helm chart received support for microservice mode, a seperate admin-api deployment is created in both SSD and Microservice modes.
Which issue(s) this PR fixes:
n/a
Special notes for your reviewer:
n/a
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR