feat(lambda-promtail): build lambda with zip file - #13787
Conversation
|
Hey @maxforasteiro . There are a lot of users who already use lamda promatail in the way it was before. |
Hey @vlad-diachenko, thanks for the quick code review! I just added the ability to either pass the image tag or generate it from the repo itself if it is absent. |
|
|
|
hey @vlad-diachenko! can you take a look now? |
sure, I will review it today |
vlad-diachenko
left a comment
There was a problem hiding this comment.
looks great. thanks @maxforasteiro
What this PR does / why we need it:
Avoid having to create ECRs repos and building image with terraform instead.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
This is my first contribution. Let me know if there's anything else I can do to get this pushed to main. Our idea is to use
tools/lambda-promtailas a module from our IaC without any extra steps. We have already implemented and tested a similar solution in our IaC and it works.Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR