Skip to content

feat(lambda-promtail): build lambda with zip file - #13787

Merged
vlad-diachenko merged 10 commits into
grafana:mainfrom
maxforasteiro:feat/build-lambda-with-zip-file
Aug 14, 2024
Merged

feat(lambda-promtail): build lambda with zip file#13787
vlad-diachenko merged 10 commits into
grafana:mainfrom
maxforasteiro:feat/build-lambda-with-zip-file

Conversation

@maxforasteiro

@maxforasteiro maxforasteiro commented Aug 7, 2024

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
Avoid having to create ECRs repos and building image with terraform instead.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
This is my first contribution. Let me know if there's anything else I can do to get this pushed to main. Our idea is to use tools/lambda-promtail as a module from our IaC without any extra steps. We have already implemented and tested a similar solution in our IaC and it works.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@maxforasteiro
maxforasteiro requested a review from a team as a code owner August 7, 2024 11:35
@CLAassistant

CLAassistant commented Aug 7, 2024

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@vlad-diachenko
vlad-diachenko self-requested a review August 7, 2024 18:34
@vlad-diachenko

Copy link
Copy Markdown
Contributor

Hey @maxforasteiro . There are a lot of users who already use lamda promatail in the way it was before.
could you change your implementation to support both schenarious?
I mean to leave it possible to use the link to the image in GCR or upload the archive directly....

@vlad-diachenko vlad-diachenko self-assigned this Aug 7, 2024
@maxforasteiro

Copy link
Copy Markdown
Contributor Author

Hey @maxforasteiro . There are a lot of users who already use lamda promatail in the way it was before. could you change your implementation to support both schenarious? I mean to leave it possible to use the link to the image in GCR or upload the archive directly....

Hey @vlad-diachenko, thanks for the quick code review! I just added the ability to either pass the image tag or generate it from the repo itself if it is absent.

@maxforasteiro

maxforasteiro commented Aug 8, 2024

Copy link
Copy Markdown
Contributor Author

hold on, it doesn't seem to work as expected, I'm performing some tests on my side fixed

@maxforasteiro

Copy link
Copy Markdown
Contributor Author

hey @vlad-diachenko! can you take a look now?

@vlad-diachenko

Copy link
Copy Markdown
Contributor

hey @vlad-diachenko! can you take a look now?

sure, I will review it today

@vlad-diachenko vlad-diachenko left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great. thanks @maxforasteiro

@vlad-diachenko vlad-diachenko changed the title Feat: build lambda with zip file Aug 14, 2024
@vlad-diachenko
vlad-diachenko merged commit 9bf08f7 into grafana:main Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 participants