Skip to content

fix: Improve execution speed for queries with label filters - #13922

Merged
MasslessParticle merged 2 commits into
grafana:mainfrom
JohanLindvall:main
Aug 19, 2024
Merged

fix: Improve execution speed for queries with label filters#13922
MasslessParticle merged 2 commits into
grafana:mainfrom
JohanLindvall:main

Conversation

@JohanLindvall

@JohanLindvall JohanLindvall commented Aug 19, 2024

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
This PR improves performance for label filters so that their order is kept w.r.t line filters.

Which issue(s) this PR fixes:
Fixes #13869

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@JohanLindvall
JohanLindvall requested a review from a team as a code owner August 19, 2024 09:29
@JohanLindvall JohanLindvall changed the title Improve execution speed for queries with label filters Aug 19, 2024
@CLAassistant

CLAassistant commented Aug 19, 2024

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@MasslessParticle

Copy link
Copy Markdown
Contributor

Nice work. Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 participants