feat(helm): ✨ add additional service annotations for components in distributed mode - #14131
Merged
trevorwhitney merged 14 commits intoSep 24, 2024
Merged
feat(helm): ✨ add additional service annotations for components in distributed mode#14131trevorwhitney merged 14 commits into
trevorwhitney merged 14 commits into
Conversation
|
|
chaudum
approved these changes
Sep 13, 2024
chaudum
left a comment
chaudum
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the contribution! LGTM
github-actions
Bot
added
the
type/docs
Contributor
Author
You're welcome, thanks for the quick review. I updated the docs, hopefully that fixes the remaining CI issues. |
Contributor
|
@dannylongeuay The Helm docs lint check still fails :/ |
Contributor
Author
|
@chaudum fixed the readme versions I missed |
mraboosk
pushed a commit
to mraboosk/loki
that referenced
this pull request
Oct 7, 2024
…stributed mode (grafana#14131) Co-authored-by: Christian Haudum <christian.haudum@gmail.com> Co-authored-by: Trevor Whitney <trevorjwhitney@gmail.com>
This was referenced Oct 14, 2024
This was referenced Oct 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Support additional service annotations for components in distributed mode.
Which issue(s) this PR fixes:
Fixes #8627
Special notes for your reviewer:
A previous PR #10214 added support for the simple scalable components, this PR adds support for the distributed mode components.
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR