Skip to content

feat: mixins / allow bloom dashboards disabling - #14177

Merged
chaudum merged 1 commit into
grafana:mainfrom
QuentinBisson:feat-mixins-hide-bloom-dashboards-if-unused
Sep 19, 2024
Merged

feat: mixins / allow bloom dashboards disabling#14177
chaudum merged 1 commit into
grafana:mainfrom
QuentinBisson:feat-mixins-hide-bloom-dashboards-if-unused

Conversation

@QuentinBisson

@QuentinBisson QuentinBisson commented Sep 19, 2024

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

This PR allows hiding the bloom dashboards if they are not useful because we are not using blooms yet for instance :D

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@QuentinBisson
QuentinBisson requested a review from a team as a code owner September 19, 2024 07:26
@QuentinBisson
QuentinBisson force-pushed the feat-mixins-hide-bloom-dashboards-if-unused branch from f1c0feb to 0dbaffe Compare September 19, 2024 07:28
@pull-request-size pull-request-size Bot added size/S and removed size/L labels Sep 19, 2024
@QuentinBisson
QuentinBisson force-pushed the feat-mixins-hide-bloom-dashboards-if-unused branch from 0dbaffe to f86fc94 Compare September 19, 2024 07:31
@pull-request-size pull-request-size Bot added size/L and removed size/S labels Sep 19, 2024
@QuentinBisson
QuentinBisson force-pushed the feat-mixins-hide-bloom-dashboards-if-unused branch from f86fc94 to 8ef7bc0 Compare September 19, 2024 07:33
@QuentinBisson QuentinBisson changed the title feat(mixins) allow bloom dashboards disabling Sep 19, 2024
@QuentinBisson
QuentinBisson force-pushed the feat-mixins-hide-bloom-dashboards-if-unused branch from 8ef7bc0 to ecdc8b1 Compare September 19, 2024 07:40
@QuentinBisson
QuentinBisson force-pushed the feat-mixins-hide-bloom-dashboards-if-unused branch from ecdc8b1 to a2ae386 Compare September 19, 2024 07:40
chaudum
chaudum approved these changes Sep 19, 2024
View reviewed changes

@chaudum chaudum left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
@chaudum
chaudum merged commit ce2e6d5 into grafana:main Sep 19, 2024
@loki-gh-app loki-gh-app Bot mentioned this pull request Sep 23, 2024
Closed
@loki-gh-app loki-gh-app Bot mentioned this pull request Sep 30, 2024
Closed
@loki-gh-app loki-gh-app Bot mentioned this pull request Oct 7, 2024
Closed
This was referenced Oct 14, 2024
Closed
Closed
This was referenced Oct 21, 2024
Closed
Closed
@loki-gh-app loki-gh-app Bot mentioned this pull request Nov 4, 2024
Merged
@loki-gh-app loki-gh-app Bot mentioned this pull request Nov 11, 2024
Closed
@loki-gh-app loki-gh-app Bot mentioned this pull request Dec 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L

2 participants

@QuentinBisson @chaudum