Skip to content

fix: Wait for OwnedStreams service in Ingester startup - #14208

Merged
cyriltovena merged 2 commits into
grafana:mainfrom
cyriltovena:fix-startup-ownedstreams
Sep 20, 2024
Merged

fix: Wait for OwnedStreams service in Ingester startup#14208
cyriltovena merged 2 commits into
grafana:mainfrom
cyriltovena:fix-startup-ownedstreams

Conversation

@cyriltovena

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

While working on a new feature I spotted that typo that seems to not correctly wait for OwnedStreams in Ingester startup.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@cyriltovena
cyriltovena requested a review from a team as a code owner September 20, 2024 10:31

@JordanRushing JordanRushing left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@cyriltovena
cyriltovena merged commit a4aee4f into grafana:main Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants