Skip to content

fix: Update AWS storage timeout error for Go 1.23 behavior - #14226

Merged
paul1r merged 1 commit into
mainfrom
paul1r/mirror_gcs_timeout_change_to_aws
Sep 23, 2024
Merged

fix: Update AWS storage timeout error for Go 1.23 behavior#14226
paul1r merged 1 commit into
mainfrom
paul1r/mirror_gcs_timeout_change_to_aws

Conversation

@paul1r

@paul1r paul1r commented Sep 23, 2024

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:
Mirrors the GCP-specific change from #14220 to AWS

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@paul1r
paul1r requested a review from a team as a code owner September 23, 2024 16:07
@paul1r
paul1r merged commit a4642b5 into main Sep 23, 2024
@paul1r
paul1r deleted the paul1r/mirror_gcs_timeout_change_to_aws branch September 23, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants