Skip to content

feat(jsonnet): Allow to name prefix zoned ingesters - #14260

Merged
cyriltovena merged 1 commit into
mainfrom
add-prefix-name-ingester-zone
Sep 26, 2024
Merged

feat(jsonnet): Allow to name prefix zoned ingesters#14260
cyriltovena merged 1 commit into
mainfrom
add-prefix-name-ingester-zone

Conversation

@cyriltovena

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@cyriltovena
cyriltovena requested a review from a team as a code owner September 25, 2024 13:18

@ashwanthgoli ashwanthgoli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena
cyriltovena merged commit fac3177 into main Sep 26, 2024
@cyriltovena
cyriltovena deleted the add-prefix-name-ingester-zone branch September 26, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants