fix(promtail): Fix API level node filtering of Kubernetes SD to only fetch pod metadata for pods of the current node - #14267
Merged
chaudum merged 3 commits intoJan 10, 2025
Conversation
LashaJini
force-pushed
the
correctly-loop-over-k8s-selectors
branch
from
September 26, 2024 08:36
c7c6748 to
8a218cb
Compare
LashaJini
commented
Sep 26, 2024
| defer client.Stop() | ||
|
|
||
| ftm, err := newTestFileTargetManager(logger, client, ps, logDirName+"/*") | ||
| assert.NoError(t, err) |
Contributor
Author
There was a problem hiding this comment.
add the missing err assertion to satisfy the linter
Contributor
Author
|
@chaudum could you please remove the invalid labels. I've accidentally pushed the wrong changes and gh actions bot didn't remove the invalid ones. |
chaudum
approved these changes
Dec 13, 2024
This was referenced Feb 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Previous behavior: loop variable
selectoris a copy of each element, thus changes to the fields is not reflected in the original slice.Current behavior: use index of the element and update directly.
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR