Skip to content

feat: Introduce new ObjectExistsWithSize API to - #14268

Merged
DylanGuedes merged 3 commits into
mainfrom
add-exists-with-size-api
Sep 25, 2024
Merged

feat: Introduce new ObjectExistsWithSize API to#14268
DylanGuedes merged 3 commits into
mainfrom
add-exists-with-size-api

Conversation

@DylanGuedes

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
Introduce a new ObjectExistsWithSize API to our object storage interface.
This is the same as ObjectExists but with the object size as part of the return value. This is useful to compare the object size present.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@DylanGuedes
DylanGuedes requested a review from a team as a code owner September 25, 2024 16:29
@DylanGuedes
DylanGuedes merged commit ac422b3 into main Sep 25, 2024
@DylanGuedes
DylanGuedes deleted the add-exists-with-size-api branch September 25, 2024 17:29
JoaoBraveCoding added a commit to JoaoBraveCoding/loki that referenced this pull request Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants