Skip to content

feat: Apply patterns line length limit to json message key - #14296

Merged
cyriltovena merged 1 commit into
grafana:mainfrom
ravishankar15:jsontokenizer-13984
Oct 2, 2024
Merged

feat: Apply patterns line length limit to json message key#14296
cyriltovena merged 1 commit into
grafana:mainfrom
ravishankar15:jsontokenizer-13984

Conversation

@ravishankar15

@ravishankar15 ravishankar15 commented Sep 27, 2024

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
Applies the limit restriction on extracted json message line

Which issue(s) this PR fixes:
Fixes #13984

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@ravishankar15
ravishankar15 requested a review from a team as a code owner September 27, 2024 14:39

@cyriltovena cyriltovena left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena
cyriltovena merged commit 41fafd8 into grafana:main Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants