fix(config): Copy Alibaba and IBM object storage configuration from common - #14315
Merged
Conversation
![grafana-delivery-bot[bot]](https://cdn.statically.io/img/github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
loki-gh-app
Bot
added
backport
size/L
type/bug
chaudum
changed the title
chaudum
approved these changes
Oct 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport 59ff1ec from #14297
What this PR does / why we need it:
This PR adds code to the
config_wrapperfor copying object storage configuration for Alibaba Cloud / IBM Cloud from the common block to the ruler and storage configuration. This code was already present for other cloud providers, it looks as if these two were missed in the implementation.Which issue(s) this PR fixes:
LOG-5325
Special notes for your reviewer:
release-3.1.xbranch.Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.