Skip to content

fix(ci): updated helm diff rendering workflow - #14424

Merged
vlad-diachenko merged 3 commits into
mainfrom
vlad.diachenko/helm-diff-workflow-fix
Oct 10, 2024
Merged

fix(ci): updated helm diff rendering workflow#14424
vlad-diachenko merged 3 commits into
mainfrom
vlad.diachenko/helm-diff-workflow-fix

Conversation

@vlad-diachenko

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

updated helm diff rendering workflow to render scenarios from BASE branch if PRs branch does not have any scenarios. It should fix the CI on outdated PRs.

…m BASE branch if PRs branch does not have any scenarios. It should fix the CI on outdated PRs.

Signed-off-by: Vladyslav Diachenko <vlad.diachenko@grafana.com>

@trevorwhitney trevorwhitney left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Vlad!

Comment thread .github/workflows/helm-loki-ci.yml Outdated
@vlad-diachenko
vlad-diachenko merged commit 916e511 into main Oct 10, 2024
@vlad-diachenko
vlad-diachenko deleted the vlad.diachenko/helm-diff-workflow-fix branch October 10, 2024 15:27
trevorwhitney added a commit that referenced this pull request Oct 10, 2024
Signed-off-by: Vladyslav Diachenko <vlad.diachenko@grafana.com>
Co-authored-by: Trevor Whitney <trevorjwhitney@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants