refactor(operator)!: Migrate project layout to kubebuilder go/v4 - #14447
Merged
Conversation
periklis
force-pushed
the
operator-go-v4-layout
branch
from
October 11, 2024 13:57
be888ea to
9a68a5b
Compare
periklis
force-pushed
the
operator-go-v4-layout
branch
from
October 14, 2024 10:37
9a68a5b to
7feb4b3
Compare
periklis
marked this pull request as ready for review
October 14, 2024 10:38
periklis
requested review from
a team,
JoaoBraveCoding and
xperimental
as code owners
October 14, 2024 10:38
JoaoBraveCoding
left a comment
JoaoBraveCoding
left a comment
Collaborator
There was a problem hiding this comment.
Overall lgtm from my side, just one question
xperimental
reviewed
Oct 17, 2024
Collaborator
|
WDYT of making the title of this PR a breaking change? The last one we did to try and advance the operator version wasn't done properly, the "!" should come after the component |
periklis
changed the title
periklis
changed the title
JoaoBraveCoding
approved these changes
Oct 21, 2024
JoaoBraveCoding
left a comment
JoaoBraveCoding
left a comment
Collaborator
There was a problem hiding this comment.
lgtm from my side
6 tasks
periklis
added a commit
to periklis/loki
that referenced
this pull request
Oct 23, 2024
periklis
added a commit
to periklis/loki
that referenced
this pull request
Oct 23, 2024
periklis
added a commit
to openshift/loki
that referenced
this pull request
Oct 24, 2024
[release-6.0] Backport PR grafana#14447
periklis
added a commit
to openshift/loki
that referenced
this pull request
Oct 24, 2024
[release-5.8] Backport PR grafana#14447
periklis
added a commit
to periklis/loki
that referenced
this pull request
Oct 24, 2024
periklis
added a commit
to openshift/loki
that referenced
this pull request
Oct 24, 2024
[release-5.9] Backport PR grafana#14447
This was referenced Nov 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Upgrades the operator project layout from kubebuilder
go/v3togo/v4. This enables to use kustomizev5and in turn re-instantiates manifest and go code scaffolding.Which issue(s) this PR fixes:
Fixes #11419
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR