Skip to content

Conversation

@mjnagel
Copy link
Contributor

@mjnagel mjnagel commented Oct 16, 2024

What this PR does / why we need it:

This sets the appProtocol of the headless backend service grpc port in the loki helm chart to tcp.

This is in line with the documentation to support deployments with Istio: https://grafana.com/docs/loki/latest/setup/install/istio/#required-changes

Which issue(s) this PR fixes:
None

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@mjnagel mjnagel requested a review from a team as a code owner October 16, 2024 17:38
@CLAassistant
Copy link

CLAassistant commented Oct 16, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

Kubernetes Manifest Diff Summary

Scenario: default-single-binary-values (Added: 0, Modified: 0, Removed: 0)

Summary:

  • Added: 0

  • Modified: 0

  • Removed: 0

Added Files

No added files

Modified Files

No modified files

Removed Files

No removed files

Scenario: default-values (Added: 0, Modified: 1, Removed: 0)

Summary:

  • Added: 0

  • Modified: 1

  • Removed: 0

Added Files

No added files

Modified Files

loki/templates/backend/service-backend-headless.yaml
*** /home/runner/work/loki/loki/output/base/default-values/loki/templates/backend/service-backend-headless.yaml	2024-12-10 17:49:09.785278577 +0000
--- /home/runner/work/loki/loki/output/pr/default-values/loki/templates/backend/service-backend-headless.yaml	2024-12-10 17:49:12.233299610 +0000
***************
*** 24,29 ****
--- 24,30 ----
 port: 9095
 targetPort: grpc
 protocol: TCP
+ appProtocol: tcp
 selector:
 app.kubernetes.io/name: loki
 app.kubernetes.io/instance: loki-test-chart-name

Removed Files

No removed files

Scenario: ingress-values (Added: 0, Modified: 1, Removed: 0)

Summary:

  • Added: 0

  • Modified: 1

  • Removed: 0

Added Files

No added files

Modified Files

loki/templates/backend/service-backend-headless.yaml
*** /home/runner/work/loki/loki/output/base/ingress-values/loki/templates/backend/service-backend-headless.yaml	2024-12-10 17:49:09.881279402 +0000
--- /home/runner/work/loki/loki/output/pr/ingress-values/loki/templates/backend/service-backend-headless.yaml	2024-12-10 17:49:12.329300433 +0000
***************
*** 24,29 ****
--- 24,30 ----
 port: 9095
 targetPort: grpc
 protocol: TCP
+ appProtocol: tcp
 selector:
 app.kubernetes.io/name: loki
 app.kubernetes.io/instance: loki-test-chart-name

Removed Files

No removed files

Scenario: legacy-monitoring-values (Added: 0, Modified: 1, Removed: 0)

Summary:

  • Added: 0

  • Modified: 1

  • Removed: 0

Added Files

No added files

Modified Files

loki/templates/backend/service-backend-headless.yaml
*** /home/runner/work/loki/loki/output/base/legacy-monitoring-values/loki/templates/backend/service-backend-headless.yaml	2024-12-10 17:49:09.985280297 +0000
--- /home/runner/work/loki/loki/output/pr/legacy-monitoring-values/loki/templates/backend/service-backend-headless.yaml	2024-12-10 17:49:12.437301359 +0000
***************
*** 24,29 ****
--- 24,30 ----
 port: 9095
 targetPort: grpc
 protocol: TCP
+ appProtocol: tcp
 selector:
 app.kubernetes.io/name: loki
 app.kubernetes.io/instance: loki-test-chart-name

Removed Files

No removed files

Scenario: simple-scalable-aws-kube-irsa-values (Added: 0, Modified: 1, Removed: 0)

Summary:

  • Added: 0

  • Modified: 1

  • Removed: 0

Added Files

No added files

Modified Files

loki/templates/backend/service-backend-headless.yaml
*** /home/runner/work/loki/loki/output/base/simple-scalable-aws-kube-irsa-values/loki/templates/backend/service-backend-headless.yaml	2024-12-10 17:49:10.097281262 +0000
--- /home/runner/work/loki/loki/output/pr/simple-scalable-aws-kube-irsa-values/loki/templates/backend/service-backend-headless.yaml	2024-12-10 17:49:12.549302319 +0000
***************
*** 24,29 ****
--- 24,30 ----
 port: 9095
 targetPort: grpc
 protocol: TCP
+ appProtocol: tcp
 selector:
 app.kubernetes.io/name: enterprise-logs
 app.kubernetes.io/instance: loki-test-chart-name

Removed Files

No removed files

@chaudum chaudum merged commit 400f5af into grafana:main Dec 11, 2024
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

3 participants