feat(logcli): add gzip compression option - #14598
Merged
Merged
Conversation
Passing --compress to logcli will enable (or more accurately not disable) compression on the http.Transport, allowing Loki to return gzip-compressed payloads. This improves overall execution time and reduces data transfer by 10-15x. Signed-off-by: Jason Tackaberry <tack@urandom.ca>
|
|
github-actions
Bot
added
the
type/docs
JStickler
reviewed
Oct 24, 2024
JStickler
left a comment
JStickler
left a comment
Contributor
There was a problem hiding this comment.
[docs team] The docs LGTM, an engineer will have to review the Go code.
chaudum
approved these changes
Oct 29, 2024
chaudum
left a comment
chaudum
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the addition!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Passing --compress to logcli will enable (or more accurately not disable) compression on the http.Transport, allowing Loki to return gzip-compressed payloads.
This improves overall execution time and reduces data transfer by 10-15x.
Which issue(s) this PR fixes:
#14597
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR