feat: move metric aggregation to a per-tenant config - #14709
Merged
Conversation
Contributor
|
This PR must be merged before a backport PR will be created. |
benclive
approved these changes
Nov 1, 2024
| f.BoolVar( | ||
| &l.MetricAggregationEnabled, | ||
| "limits.metric-aggregation-enabled", | ||
| false, |
Contributor
There was a problem hiding this comment.
Could/should we default this to true?
Collaborator
Author
There was a problem hiding this comment.
It would make the deployment easier. My big concern is the surprise for OSS users, as I'd still consider it a beta/experimental feature.
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-14709-to-k226 origin/k226
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x c1fde26730b4fc54e4bbc724d1b29f653541f720When the conflicts are resolved, stage and commit the changes: If you have the GitHub CLI installed: # Push the branch to GitHub:
git push --set-upstream origin backport-14709-to-k226
# Create the PR body template
PR_BODY=$(gh pr view 14709 --json body --template 'Backport c1fde26730b4fc54e4bbc724d1b29f653541f720 from #14709{{ "\n\n---\n\n" }}{{ index . "body" }}')
# Create the PR on GitHub
echo "${PR_BODY}" | gh pr create --title 'feat: move metric aggregation to a per-tenant config (backport k226)' --body-file - --label 'size/L' --label 'type/docs' --label 'product-approved' --label 'backport' --base k226 --milestone k226 --webOr, if you don't have the GitHub CLI installed (we recommend you install it!): # Push the branch to GitHub:
git push --set-upstream origin backport-14709-to-k226
# Create a pull request where the `base` branch is `k226` and the `compare`/`head` branch is `backport-14709-to-k226`.
# Remove the local backport branch
git switch main
git branch -D backport-14709-to-k226 |
trevorwhitney
added a commit
that referenced
this pull request
Nov 1, 2024
(cherry picked from commit c1fde26)
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This moves the metric aggregation feature flag to a per-tenant config
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR