Skip to content

feat: Add otlp attribute deployment.environment.name to list of default labels #14747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 18, 2024
Merged

feat: Add otlp attribute deployment.environment.name to list of default labels #14747

merged 5 commits into from
Nov 18, 2024

Conversation

@mveitas
Copy link
Contributor

@mveitas mveitas commented Nov 2, 2024 •
edited by cyrille-leclerc
Loading

What this PR does / why we need it:
Adds the deployment.environment.name to the list of default resource attributes that are promoted to an index label.

Which issue(s) this PR fixes:
Fixes #14658

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@mveitas mveitas requested a review from a team as a code owner November 2, 2024 22:23
@CLAassistant
Copy link

CLAassistant commented Nov 2, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Nov 2, 2024
@mveitas mveitas changed the title feat: Add deployment.environment.name as otlp resource attribute to list of default labels Nov 3, 2024
@mveitas mveitas force-pushed the deployment-environment-name-label branch from 8e1eb85 to 02baad6 Compare November 5, 2024 02:23
trevorwhitney
trevorwhitney approved these changes Nov 6, 2024
View reviewed changes
Copy link
Collaborator

@trevorwhitney trevorwhitney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding this
@trevorwhitney
Copy link
Collaborator

looks like you just need to rebuild the docs make docs and we can get this in
@mveitas
Copy link
Contributor Author

mveitas commented Nov 17, 2024

@trevorwhitney MR has been updated with doc generation
@trevorwhitney trevorwhitney merged commit 2d407bd into grafana:main Nov 18, 2024
58 checks passed
thevops pushed a commit to thevops/loki that referenced this pull request Nov 21, 2024
@matt-veitas-eb @thevops
feat: Add otlp attribute deployment.environment.name to list of defau…
6b1314f 
…lt labels (grafana#14747)
This was referenced Dec 23, 2024
Closed
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Jan 6, 2025
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Jan 13, 2025
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Jan 20, 2025
Closed
This was referenced Feb 3, 2025
Closed
Merged
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Feb 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories

4 participants

@mveitas @CLAassistant @trevorwhitney @matt-veitas-eb