Skip to content

Conversation

@periklis
Copy link
Collaborator

@periklis periklis commented Nov 7, 2024

What this PR does / why we need it:
Fixes warnings as mentioned in the latest release pipeline reports:

  • k8s-operator-hub/communit-operators: 0.7.0
  • redhat-openshift-ecosystem/community-operators-prod: 0.7.0

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
Copy link
Collaborator

@JoaoBraveCoding JoaoBraveCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall lgtm just one comment/question

Copy link
Collaborator

@JoaoBraveCoding JoaoBraveCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran static tests and deployed community version ✅
lgtm

@periklis periklis merged commit e707a3d into grafana:main Nov 7, 2024
66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

2 participants