Skip to content

Conversation

@paumr
Copy link
Contributor

@paumr paumr commented Nov 8, 2024

What this PR does / why we need it:
If a query exceeds it's configured limit it returns an error-message.
This message currently references the (invalid) setting max_entries_limit, instead max_entries_limit_per_query should be used.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@paumr paumr requested a review from a team as a code owner November 8, 2024 12:13
@CLAassistant
Copy link

CLAassistant commented Nov 8, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@chaudum chaudum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paumr Thanks for your contribution!

@chaudum chaudum merged commit f5ae015 into grafana:main Nov 11, 2024
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 participants