feat: expose topologySpreadConstraints for distributed deployment #14853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
area/helm
type/docs
This comment has been minimized.
This comment has been minimized.
…aints-for-distributed-deployment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
trevorwhitney
requested changes
Nov 12, 2024
| {{- toYaml . | nindent 8 }} | ||
| {{- end }} | ||
| spec: | ||
| {{- if semverCompare ">=1.19-0" .Capabilities.KubeVersion.GitVersion }} |
There was a problem hiding this comment.
can we please use KubeVersion instead? GitVersion appears to be deprecated and really confused me, haha
There was a problem hiding this comment.
Done! Sorry about that 😁
…aints-for-distributed-deployment
This comment has been minimized.
This comment has been minimized.
Kubernetes Manifest Diff SummaryScenario: default-single-binary-values (Added: 0, Modified: 0, Removed: 0)
Summary:
Added FilesNo added files Modified FilesNo modified files Removed FilesNo removed files Scenario: default-values (Added: 0, Modified: 0, Removed: 0)
Summary:
Added FilesNo added files Modified FilesNo modified files Removed FilesNo removed files Scenario: ingress-values (Added: 0, Modified: 0, Removed: 0)
Summary:
Added FilesNo added files Modified FilesNo modified files Removed FilesNo removed files Scenario: legacy-monitoring-values (Added: 0, Modified: 0, Removed: 0)
Summary:
Added FilesNo added files Modified FilesNo modified files Removed FilesNo removed files Scenario: simple-scalable-aws-kube-irsa-values (Added: 0, Modified: 1, Removed: 0)
Summary:
Added FilesNo added files Modified Filesloki/templates/gateway/deployment-gateway-enterprise.yaml*** /home/runner/work/loki/loki/output/base/simple-scalable-aws-kube-irsa-values/loki/templates/gateway/deployment-gateway-enterprise.yaml 2024-11-13 00:53:48.702267812 +0000
--- /home/runner/work/loki/loki/output/pr/simple-scalable-aws-kube-irsa-values/loki/templates/gateway/deployment-gateway-enterprise.yaml 2024-11-13 00:53:50.882285224 +0000
***************
*** 29,35 ****
app.kubernetes.io/component: gateway
annotations:
checksum/config: 4a89247c5f729aa7f742986de6f9a88a88f538f66b6b811414428c60920e5934
! spec:
serviceAccountName: enterprise-logs
securityContext:
fsGroup: 10001
--- 29,35 ----
app.kubernetes.io/component: gateway
annotations:
checksum/config: 4a89247c5f729aa7f742986de6f9a88a88f538f66b6b811414428c60920e5934
! spec:
serviceAccountName: enterprise-logs
securityContext:
fsGroup: 10001Removed FilesNo removed files |
trevorwhitney
deleted the
14836-helm-chart-expose-topologyspreadconstraints-for-distributed-deployment
branch
6 tasks
This was referenced Dec 23, 2024
This was referenced Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Exposes
topologySpreadConstraintsfields for resources in distributed environments, allowing for consistent resource configuration.Which issue(s) this PR fixes:
Fixes #14836
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR