Skip to content

Conversation

@trevorwhitney
Copy link
Collaborator

What this PR does / why we need it:

#14350 introduced detected field values, and refactored our routing logic. In doing so I left out the /api bit in /api/prom/label/{name}/values as referenced here. This fixes that mistake.

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • [ x] If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@trevorwhitney trevorwhitney requested a review from a team as a code owner November 14, 2024 18:03
@trevorwhitney trevorwhitney merged commit 8ce321e into main Nov 15, 2024
57 checks passed
@trevorwhitney trevorwhitney deleted the fix-legacy-label-endpoint branch November 15, 2024 16:11
thevops pushed a commit to thevops/loki that referenced this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants