Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(thanos): add new metric to track status codes #14937

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

ashwanthgoli
Copy link
Contributor

What this PR does / why we need it:
Thanos objstore metrics do not track the status code of operations. objstore_bucket_operation_failures_total only reports if an operation failed, but nothing more.

this pr adds a new metric loki_objstore_bucket_transport_requests_total to observe the total requests by status code and the http method. Since we are directly wrapping the transport we cannot partition the metric by the object store operation type (get, list...) instead this metric reports the http method.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@ashwanthgoli ashwanthgoli marked this pull request as ready for review November 15, 2024 12:12
@ashwanthgoli ashwanthgoli requested a review from a team as a code owner November 15, 2024 12:12
@ashwanthgoli ashwanthgoli merged commit a629212 into main Nov 15, 2024
59 checks passed
@ashwanthgoli ashwanthgoli deleted the thanos-statuscode branch November 15, 2024 14:09
thevops pushed a commit to thevops/loki that referenced this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 participants