Skip to content

Conversation

@chaudum
Copy link
Contributor

@chaudum chaudum commented Nov 15, 2024

What this PR does / why we need it:

The metrics.go log line contains the index_used_bloom_filter field, which was not set to true when the query used bloom filters in the GetChunkRef() call on the index gateway.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
@chaudum chaudum requested a review from a team as a code owner November 15, 2024 15:23
Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@chaudum chaudum merged commit ff111dc into main Nov 15, 2024
59 checks passed
@chaudum chaudum deleted the chaudum/fix-used-bloom-filter-logline branch November 15, 2024 15:30
thevops pushed a commit to thevops/loki that referenced this pull request Nov 21, 2024
…14941)

Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 participants