feat: add opt-in support for ProxyFroomEnvironment in logcli (#11742) #14950
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is enabled with the --envproxy flag. This is opt in because for a very small subset of users, it may cause a breaking change. If a user has a proxy url configured but also sets a HTTP_PROXY variable, then this will cause an error in the request.
What this PR does / why we need it:
HTTP_PROXY is a standard approach to configuring CLIs.
In my use-case, it allows me to use an internal tool to do proxy oauth so I can use logcli via CLI behind auth.
Which issue(s) this PR fixes:
Fixes #11742
Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
deprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR