Skip to content

feat: Add Rule Name and Type to Query Tags #15055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jan 10, 2025
Merged

feat: Add Rule Name and Type to Query Tags #15055

merged 9 commits into from
Jan 10, 2025

Conversation

@bentonam
Copy link
Contributor

What this PR does / why we need it:

When the ruler evaluation is remote, the only query tag set is source=ruler. When identifying problematic queries it would be more useful to have more than just the query and source=ruler. This adds support to also set the rule_name and rule_type.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Eventually, we may need to add namespace and group

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@bentonam bentonam requested a review from cstyan November 21, 2024 18:15
@bentonam bentonam requested a review from a team as a code owner November 21, 2024 18:15
@CLAassistant
Copy link

CLAassistant commented Nov 21, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.
chaudum
chaudum reviewed Dec 9, 2024
View reviewed changes
@cstyan
add a log line request timings that could be propagated to usage
0356675 
insights within grafana cloud for grafana cloud logs users

Signed-off-by: Callum Styan <callumstyan@gmail.com>
@cstyan
lint
8936da2 
Signed-off-by: Callum Styan <callumstyan@gmail.com>
@cstyan
only log the request timings log line if there was not an error
faa39b5 
executing the query (includes the response not being JSON, which would
result in there being no query statistics struct)

Signed-off-by: Callum Styan <callumstyan@gmail.com>
@cstyan
we don't want to log the additional context of rule evaluation when
d1ea7be 
logging to insights logs

Signed-off-by: Callum Styan <callumstyan@gmail.com>
@pull-request-size pull-request-size bot added size/L and removed size/M labels Dec 17, 2024
@chaudum chaudum merged commit b272573 into main Jan 10, 2025
59 checks passed
@chaudum chaudum deleted the benton/ruler-tags branch January 10, 2025 13:14
@loki-gh-app loki-gh-app bot mentioned this pull request Jan 13, 2025
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Jan 20, 2025
Closed
This was referenced Feb 3, 2025
Closed
Merged
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Feb 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L

4 participants

@bentonam @CLAassistant @chaudum @cstyan