Skip to content

fix: remove enabled field in loki-local-config.yaml #15059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 25, 2024
Merged

fix: remove enabled field in loki-local-config.yaml #15059

merged 1 commit into from
Nov 25, 2024

Conversation

@chenrui333
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #15039

relates to Homebrew/homebrew-core#198450

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@chenrui333
fix: remove enabled field in loki-local-config.yaml
5c85420 
Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333 chenrui333 requested a review from a team as a code owner November 21, 2024 20:37
@CLAassistant
Copy link

CLAassistant commented Nov 21, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.
trevorwhitney
trevorwhitney approved these changes Nov 23, 2024
View reviewed changes
Copy link
Collaborator

@trevorwhitney trevorwhitney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!
@DylanGuedes DylanGuedes merged commit 7410f10 into grafana:main Nov 25, 2024
59 checks passed
@trevorwhitney trevorwhitney mentioned this pull request Dec 6, 2024
Merged
6 tasks
@loki-gh-app loki-gh-app bot mentioned this pull request Dec 9, 2024
Merged
6 tasks
@pbjhelmert pbjhelmert mentioned this pull request Dec 17, 2024
Open
@chenrui333 chenrui333 mentioned this pull request Dec 18, 2024
Merged
6 tasks
This was referenced Dec 23, 2024
Closed
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Jan 6, 2025
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Jan 13, 2025
Closed
@trevorwhitney trevorwhitney added type/bug Somehing is not working as expected backport release-3.3.x labels Jan 15, 2025
@trevorwhitney trevorwhitney mentioned this pull request Jan 15, 2025
Merged
6 tasks
@loki-gh-app loki-gh-app bot mentioned this pull request Jan 20, 2025
Closed
This was referenced Feb 3, 2025
Closed
Merged
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Feb 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport release-3.3.x size/XS type/bug Somehing is not working as expected

4 participants

@chenrui333 @CLAassistant @trevorwhitney @DylanGuedes