Skip to content

fix(metric_aggregation): Fix duplicate metrics registration - #15142

Merged
shantanualsi merged 4 commits into
mainfrom
shantanu/fix-pattern-ingester-duplicate-reg
Nov 27, 2024
Merged

fix(metric_aggregation): Fix duplicate metrics registration#15142
shantanualsi merged 4 commits into
mainfrom
shantanu/fix-pattern-ingester-duplicate-reg

Conversation

@shantanualsi

@shantanualsi shantanualsi commented Nov 27, 2024

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Fixes duplicate metric registration in metric aggregation in pattern ingesters. I used promauto.With(reg) along with m.reg.MustRegister(... that resulted in duplicate registration

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@shantanualsi
shantanualsi requested a review from a team as a code owner November 27, 2024 06:25
@pull-request-size pull-request-size Bot added size/M and removed size/S labels Nov 27, 2024
@pull-request-size pull-request-size Bot added size/L and removed size/M labels Nov 27, 2024

@ashwanthgoli ashwanthgoli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ashwanthgoli ashwanthgoli added type/bug Somehing is not working as expected backport k230 labels Nov 27, 2024
@loki-gh-app

loki-gh-app Bot commented Nov 27, 2024

Copy link
Copy Markdown
Contributor

This PR must be merged before a backport PR will be created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport k230 size/L type/bug Somehing is not working as expected

2 participants