Skip to content

feat: add phase to log lines in kafka_consumer.go #15176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2024
Merged

feat: add phase to log lines in kafka_consumer.go #15176

merged 1 commit into from
Nov 28, 2024

Conversation

@grobinson-grafana
Copy link
Contributor

@grobinson-grafana grobinson-grafana commented Nov 28, 2024 •
edited
Loading

What this PR does / why we need it:

This commit adds the phase to the log lines in kafka_consumer.go to make it easier to understand if the ingester is in starting phase or in running phase.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@grobinson-grafana grobinson-grafana requested a review from a team as a code owner November 28, 2024 11:41
@grobinson-grafana grobinson-grafana force-pushed the grobinson/add-phase-to-log-lines branch from cb4713c to 3b63ef6 Compare November 28, 2024 11:42
@grobinson-grafana
feat: add phase to log lines in kafka_consumer.go
470b3fc 
This commit adds the phase to the log lines in kafka_consumer.go to
make it easier to understand if the ingester is in starting phase
or in running phase.
@grobinson-grafana grobinson-grafana force-pushed the grobinson/add-phase-to-log-lines branch from 3b63ef6 to 470b3fc Compare November 28, 2024 11:48
cyriltovena
cyriltovena approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
ashwanthgoli
ashwanthgoli approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@ashwanthgoli ashwanthgoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@grobinson-grafana grobinson-grafana merged commit 0a12cab into main Nov 28, 2024
58 checks passed
@grobinson-grafana grobinson-grafana deleted the grobinson/add-phase-to-log-lines branch November 28, 2024 13:20
This was referenced Dec 23, 2024
Closed
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Jan 6, 2025
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Jan 13, 2025
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Jan 20, 2025
Closed
This was referenced Feb 3, 2025
Closed
Merged
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Feb 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M

3 participants

@grobinson-grafana @cyriltovena @ashwanthgoli